fix(SOF-8032): add grace period before deleting non-tip WIP releases - #48
Open
k0stik wants to merge 2 commits into
Open
fix(SOF-8032): add grace period before deleting non-tip WIP releases#48k0stik wants to merge 2 commits into
k0stik wants to merge 2 commits into
Conversation
Staleness was decided purely by "is this tag's sha still a branch tip" (git ls-remote --heads). That broke job-designer's build: ive's wip-2a8a93e was still pinned in job-designer/package.json, but a later commit on the same ive branch (with no [release] tag of its own) moved the tip past it, so the next Monday's scheduled cleanup deleted it - 404ing job-designer's `npm install`. Add min-age-days (default 14) as a second, independent gate: a non-tip release is only deleted once it's also older than the grace period, giving a pinned-but-superseded tarball time to get noticed and repinned before it's swept. Existing callers pick this up via the default with no changes needed, since all 22 mat3ra/* repos invoke this reusable workflow without overriding the new input.
timurbazhirov
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup-wip-releases.yml's only staleness check was "is this tag's sha still a branch tip" (git ls-remote --heads) — a release stops counting as a branch tip the moment ANY new commit lands on that branch, regardless of whether another repo'spackage.jsonstill depends on that exact tarball.job-designer's Netlify build:ive'swip-2a8a93ewas pinned injob-designer/package.json, but a later commit onive's same branch (no[release]tag of its own) moved the tip past it, so the next scheduled Monday cleanup deleted it — 404ingnpm install.min-age-days(default 14) as a second, independent AND-gate: a non-tip release is only deleted once it's also older than the grace period.Why this shape
mat3ra/*callers of this reusable workflow pick up the new default with zero changes on their end.Test plan
yamllintclean except two pre-existing warnings unrelated to this change (verified viagit stashdiff)date -u -dage arithmetic against real GNU date in anubuntu:24.04container (matchesruns-on: ubuntu-latest), confirming a 4-day-old release correctly evaluates as "keep" under the 14-day defaultghauth against a target repo)🤖 Generated with Claude Code